Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix package and changelog updates on release #2084

Merged
merged 1 commit into from
Dec 23, 2021
Merged

Conversation

cutterbl
Copy link
Collaborator

Updates to the Release GitHub Action to properly update the CHANGELOG and push release number updates to the package.json on release.

@cutterbl cutterbl requested a review from jquense December 20, 2021 19:53
@cutterbl cutterbl added the bug label Dec 20, 2021
@cutterbl cutterbl merged commit 559d585 into master Dec 23, 2021
@cutterbl cutterbl deleted the ci/buildRelease branch December 23, 2021 05:05
@cutterbl cutterbl restored the ci/buildRelease branch December 23, 2021 05:13
@cutterbl
Copy link
Collaborator Author

@jquense After implementing release changes, the process now fails due to permissions on the GITHUB_TOKEN and the master branch protection. Since the new process will autoupdate the version in the package.json, as well as update the CHANGELOG.md, it currently fails trying to push the changes to master. Either the current token user is not an 'administrator' with write permissions, or the branch protection rule is setup to also require review from administrators (include administrators checkbox). This will block releases until it's resolved.

@cutterbl
Copy link
Collaborator Author

@jquense The issue I described in my last comment is still an issue, blocking new releases.

@github-actions
Copy link

github-actions bot commented Jan 4, 2022

🎉 This PR is included in version 0.38.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@cutterbl cutterbl deleted the ci/buildRelease branch January 4, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants