Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add appearance: button for cross-browser compatibility with -webkit-appearance: button #2676

Closed
3 tasks done
in-ch opened this issue Nov 8, 2024 · 0 comments · Fixed by #2677
Closed
3 tasks done

Comments

@in-ch
Copy link
Contributor

in-ch commented Nov 8, 2024

Clear and concise description of the problem

link: https://github.com/jquense/react-big-calendar/blob/master/src/sass/reset.scss

Currently, the CSS for button styling uses only -webkit-appearance: button, which ensures consistent styling across WebKit-based browsers (e.g., Chrome, Safari). However, the CSS property appearance: button is now part of the standard specification and is supported by a wider range of modern browsers, including Firefox.

To improve cross-browser compatibility and align with the CSS specification, we should include appearance: button in addition to -webkit-appearance: button. This will provide a more consistent button appearance across all major browsers that support the standard appearance property, while maintaining compatibility with older WebKit-based browsers via the -webkit-appearance fallback.

스크린샷 2024-11-08 오후 11 36 27

Suggested solution

Add appearance: button; alongside -webkit-appearance: button; in the button CSS.
This will ensure that browsers supporting the standard appearance property apply it, while browsers that rely on -webkit-appearance will continue to function as expected.

Alternative

No response

Additional context

No response

Validations

  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Would you like to open a PR for this feature?

  • I'm willing to open a PR
in-ch added a commit to in-ch/react-big-calendar that referenced this issue Nov 8, 2024
in-ch added a commit to in-ch/react-big-calendar that referenced this issue Nov 25, 2024
cutterbl pushed a commit that referenced this issue Nov 25, 2024
#2677)

* fix: add appearance: button for better cross-browser button styling compatibility (#2676)

* fix: remove -webkit-appearance: button; for cleanup (#2677)
github-actions bot pushed a commit that referenced this issue Nov 25, 2024
## [1.16.1](v1.16.0...v1.16.1) (2024-11-25)

### Bug Fixes

* add appearance: button for better cross-browser button styling c… ([#2677](#2677)) ([85be249](85be249)), closes [#2676](#2676)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant