Setting a view as 'false' in views prop should turn it off

[kronaemmanuel]

Check that this is really a bug

• I confirm

Reproduction link

https://codesandbox.io/s/react-big-calendar-example-forked-o0b8z0?file=/src/App.js

Bug description

The documentation for creating a custom view shows this pattern being used:

const {views, ...otherProps} = useMemo(() => ({
  views: {
    month: true,
    week: CustomWeekView,
    day: true
  },
  // ... other props
}), [])

This makes it seem like if I pass day: false, the day view will disappear. However, that's not the case.

I would be happy to explore the codebase a little and fix this. Lemme know.

Expected Behavior

The day view should disappear when day: false is passed to the views prop.

Actual Behavior

The day view still appears, and it displays the error: View.title is not a function because it is still expecting for there to be a view there.

react-big-calendar version

1.5.0

React version

18.2.0

Platform/Target and Browser Versions

Firefox 104.0

Validations

• Read the docs.
• Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
• Make sure this is a react-big-calendar issue and not an implementation issue

Would you like to open a PR for this bug?

• I'm willing to open a PR

[bu6n]

You can hide the view by just not writing it, like:

const {views, ...otherProps} = useMemo(() => ({
  views: {
    month: true,
    week: CustomWeekView,
  },
  // ... other props
}), [])

This is still a bug, since the documentation says you should be able to write day: false. I think the problematic code is somewhere here:
https://github.com/jquense/react-big-calendar/blob/master/src/Calendar.js#L958

[jalalmanafi]

Hi @bu6n , is this issue still active ? I want to work on this

[bu6n]

Yes this is still a bug if you wanna try to solve it!

[jalalmanafi]

Great, can you assign me this issue?

[jalalmanafi]

@bu6n I searched the codebase, i found this, there has no boolean type month or day props. That is why it is not working for the "day or month view". Also, we can send any props to views and this will make a visual bug too. I found the file where written PropsTypes for the views prop and I will work on this, any feedback or advice is welcome :)

[rajeshmn47]

Hi @bu6n , is this issue still active ? I want to work on this.I already found solution.

[rajeshmn47]

we can fix using this

[bu6n]

Can you make a PR and then someone will review?

[rajeshmn47]

i am making it

…

On Wed, Feb 15, 2023 at 5:58 PM Billy ***@***.***> wrote: Can you make a PR and then someone will review? — Reply to this email directly, view it on GitHub <#2316 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AF45Y2ZVVXKGPPVU4DVJPIDWXTDWRANCNFSM6AAAAAATARM5DA> . You are receiving this because you commented.Message ID: ***@***.***>