Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit the PR for date-fns localizer #1541

Closed
harel opened this issue Dec 4, 2019 · 4 comments
Closed

Revisit the PR for date-fns localizer #1541

harel opened this issue Dec 4, 2019 · 4 comments
Labels

Comments

@harel
Copy link
Contributor

harel commented Dec 4, 2019

Do you want to request a feature or report a bug?

A now closed issue and PR dealt with adding date-fns as a localizer. It was determined to wait until date-fns has reached 2.0 release which has now happened a while ago.

Original Issue: #816
Original PR: #855

Would it be possible to revisit the PR now that date-fns is released?

New PR for consideration: #1542

@harel
Copy link
Contributor Author

harel commented Dec 4, 2019

Alternatively, because the DateLocalizer is now exported, it is possible to decouple the localizers completely from the Calendar code. I'm currently running the localizer in the PR I posted in my app code as a utility and use it to init the calendar instead of having a built in version. This can allow localizers to be separate packages or utilities if this becomes the norm.

@stale
Copy link

stale bot commented Feb 2, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 2, 2020
@make-github-pseudonymous-again
Copy link

make-github-pseudonymous-again commented Jan 7, 2021

Can this issue be closed now that #1542 is merged?

@harel
Copy link
Contributor Author

harel commented Jan 7, 2021

fine with me :)

@harel harel closed this as completed Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants