fix: foreach should not break init backtracking with DUPN
#3266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanwren
force-pushed
the
kanwren/foreach-dupn
branch
from
e88fb0c to
9e11573
Compare
Simplifies the compilation of `foreach` to avoid the problem in jqlang#3227 by removing unnecessary `FORK ... BACKTRACK`. Does not address `reduce`, which is less trivial.
kanwren
force-pushed
the
kanwren/foreach-dupn
branch
from
9e11573 to
def2639
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the compilation of
foreachto avoid the problem in #3227 by removing unnecessaryFORK ... BACKTRACK. Adds a simple regression test to check that theinitclause is allowed to backtrack.Does not address
reduce, which is less trivial, and may require changes to the instruction set or other tradeoffs.