Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oss-fuzz/issues/detail?id=68056 #3148

Open
pkoppstein opened this issue Jul 9, 2024 · 0 comments · May be fixed by #3260
Open

oss-fuzz/issues/detail?id=68056 #3148

pkoppstein opened this issue Jul 9, 2024 · 0 comments · May be fixed by #3260

Comments

@pkoppstein
Copy link
Contributor

Describe the bug

OSS-FUZZ is unhappy with a filter that uses _nwise(0).

Note that _nwise(0) typically behaves like recurse([]), and one could argue that the def of _nwise/1
is just fine. If the current behavior is judged to be acceptable, what should be done about 68056?

To Reproduce

[1] | _nwise(0)

Expected behavior
If the current behavior is deemed unsatisfactory, how should the def be altered?
Plausible alternatives would include:

def _nwise($n):
  def n: if length <= $n then . else .[0:$n] , (.[$n:] | n) end;
  if $n <= 0 then empty
  else n
  end;

and similar alternatives, e.g. replacing empty above with a call to error.
(Since the guard is outside def n, the performance impact would be negligible.)

Additional context
Neither gojq nor jaq define _nwise/1.
itchyny added a commit to itchyny/jq that referenced this issue Feb 16, 2025
@itchyny
refactor splits/2 using foreach syntax (remove private filter _nwise)
4c2fcd4 
This commit refactors `splits/2` implementation using `foreach` syntax
and reduces intermediate arrays. This refactoring removes an unnecessary
private (and undocumented) filter `_nwise` and closes jqlang#3148.
@itchyny itchyny linked a pull request Feb 16, 2025 that will close this issue
Open
itchyny added a commit to itchyny/jq that referenced this issue Feb 16, 2025
@itchyny
Refactor splits/2 using foreach syntax (remove private filter _nwise)
c943b47 
This commit refactors `splits/2` implementation using `foreach` syntax
and reduces intermediate arrays. This refactoring removes an unnecessary
private (and undocumented) filter `_nwise` and closes jqlang#3148.
itchyny added a commit to itchyny/jq that referenced this issue Feb 16, 2025
@itchyny
Refactor splits/2 using foreach syntax (remove private filter _nwise)
f617fa5 
This commit refactors `splits/2` implementation using `foreach` syntax
and reduces intermediate arrays. This refactoring removes an unnecessary
private (and undocumented) filter `_nwise` and closes jqlang#3148.
itchyny added a commit to itchyny/jq that referenced this issue Feb 17, 2025
@itchyny
Refactor splits/2 using foreach syntax (remove private filter _nwise)
95ed68f 
This commit refactors `splits/2` implementation using `foreach` syntax
and reduces intermediate arrays. This refactoring removes an unnecessary
private (and undocumented) filter `_nwise` and closes jqlang#3148.
itchyny added a commit to itchyny/jq that referenced this issue Feb 17, 2025
@itchyny
Refactor splits/2 using foreach syntax (remove private filter _nwise)
66e26e0 
This commit refactors `splits/2` implementation using `foreach` syntax
and reduces intermediate arrays. This refactoring removes an unnecessary
private (and undocumented) filter `_nwise` and closes jqlang#3148.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor splits/2 using foreach syntax (remove private filter _nwise) itchyny/jq
1 participant
@pkoppstein