Remove server and replace with only port #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the app to become simpler for many reasons: * Allows for easy setup in an app * Removes complex two part function for people who have split up app and server (this reverses #71) This commit closes #95 as it allows the reload path to be configured, allowing someone to use the `reload` route in their application if they needed outside of reload. This commit refactors the params again to start with the only required argument app, everything else has defaults and is in an optional object param.
…Invalid arguments are checked for to the best of our ability
|
Going to merge since it's going into V2. Should be able to do a full review once it makes it there |
|
This closes #102 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
reloadroute in their application if they needed outside of reload.