Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fs.createOutputStream() #192

Closed
jprichardson opened this issue Nov 11, 2015 · 2 comments
Closed

Remove fs.createOutputStream() #192

jprichardson opened this issue Nov 11, 2015 · 2 comments
Milestone

Comments

@jprichardson
Copy link
Owner

Recently I was using fs.createOutputStream() in https://github.com/jprichardson/node-cfs/blob/0.5.0/index.js#L30 and I was getting some weird errors. The problem is that fs.createOutputStream is a hack that is NOT heavily tested. It doesn't seem to belong in this library.

I will almost certainly create a separate module for it and remove it entirely from fs-extra.

@jprichardson jprichardson added this to the 1.0 milestone Nov 11, 2015
@jprichardson jprichardson reopened this Apr 17, 2016
@donaldpipowitch
Copy link

Was the only reason for this removal, because it was not heavily tested? :( Sad to see this go.

@jprichardson
Copy link
Owner Author

jprichardson commented Jun 16, 2016

@donaldpipowitch sorry 😞 Yeah, I felt that because it has weird edge cases on different Node versions, that it may hold the entire library back. So I thought it was best to remove it. Rest assured though, it's still alive, just in a separate module: https://github.com/jprichardson/create-output-stream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants