Replace os.path with fs.path in fsmanager.py #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
timkpaine
force-pushed
the
fix-path-join-149
branch
from
4ece0e0 to
8955e05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge changes the call to os.path.join() in fsmanager.py, which fails on Windows (see #149 ), with a call to fs.path.join(), which works correctly.
I've not been able to test this by installing the package, as I'm not familiar with building node.js modules, but I have tested it by making the same change by hand in my installed site-packages/jupyter-fs. This works for most regular directories, but fails for "My Pictures" etc. on Windows, which are fairly special directories.