Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rename action #138

Merged
merged 3 commits into from
Apr 24, 2022
Merged

Add rename action #138

merged 3 commits into from
Apr 24, 2022

Conversation

reoono
Copy link
Contributor

@reoono reoono commented Apr 13, 2022

References

Relates to telamonian/tree-finder#51

Summary

Implemented Rename function in the right-click menu. Please review and confirm the operation in the binder.

Please note the following points.

  • The implementation of the edit box and function names is based on jupyterlab's default file browser.
  • As mentioned in the comments, tree-finder's renamerSub is not yet functional, so the model update inside tree-finder is also done by jupyter-fs.

@github-actions
Copy link

Binder Launch a binder notebook on branch reoono/jupyter-fs/add-rename

@timkpaine timkpaine merged commit 7387ef6 into jpmorganchase:main Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants