Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedicated front-end tests (in separate projects?) #296

Closed
tsaglam opened this issue Feb 23, 2022 · 2 comments
Closed

Dedicated front-end tests (in separate projects?) #296

tsaglam opened this issue Feb 23, 2022 · 2 comments
Labels
enhancement Issue/PR that involves features, improvements and other changes language PR / Issue deals (partly) with new and/or existing languages for JPlag major Major issue/feature/contribution/change

Comments

@tsaglam
Copy link
Member

tsaglam commented Feb 23, 2022

Test cases for frontends, such as the Java Feature Test, should not reside in the core projects. Rather, they should be distributed into their respective frontends. However, if these require a full JPlag run, they cannot reside in the frontend project, as they only have a dependency on the front-end utils. Thus, we may need dedicated test projects for the front-ends.

This is the current dependency graph:

graph BT;
    java("Java Frontend")-->utils("Frontend Utilities");
    jplag("JPlag Core")-->utils;
    cpp("C/C++ Frontend")-->utils;
    jplag-->java;
    jplag-->cpp;

    click jplag "https://github.com/jplag/JPlag/tree/master/jplag" _blank
    click java "https://github.com/jplag/JPlag/tree/master/jplag.frontend.java" _blank
    click cpp "https://github.com/jplag/JPlag/tree/master/jplag.frontend.cpp" _blank
    click utils "https://github.com/jplag/JPlag/tree/master/jplag.frontend-utils" _blank
Loading

This is my proposed solution:

graph BT;
    java("Java Frontend")-->utils("Frontend Utilities");
    cpp("C/C++ Frontend")-->utils;
    jplag("JPlag Core")-->java;
    jplag-->utils;
    jplag-->cpp;
    jtest("Java Test Project")-->java;
    jtest-->jplag;
    cpptest(C/C++ Test Project)-->jplag;
    cpptest-->cpp;

    click jplag "https://github.com/jplag/JPlag/tree/master/jplag" _blank
    click java "https://github.com/jplag/JPlag/tree/master/jplag.frontend.java" _blank
    click cpp "https://github.com/jplag/JPlag/tree/master/jplag.frontend.cpp" _blank
    click utils "https://github.com/jplag/JPlag/tree/master/jplag.frontend-utils" _blank
Loading

Unrelated: mermaid in markdown is dope!

@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes major Major issue/feature/contribution/change language PR / Issue deals (partly) with new and/or existing languages for JPlag labels Feb 23, 2022
@tsaglam
Copy link
Member Author

tsaglam commented May 4, 2022

Lightweight frontend test cases that do not depend on the JPlag core can now be defined in the frontend projects themselves.
For details see #408.

@tsaglam
Copy link
Member Author

tsaglam commented Sep 15, 2022

Closed, as we currently employ lightweight language module tests that do not depend on the JPlag core.

@tsaglam tsaglam closed this as completed Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue/PR that involves features, improvements and other changes language PR / Issue deals (partly) with new and/or existing languages for JPlag major Major issue/feature/contribution/change
Projects
None yet
Development

No branches or pull requests

1 participant