Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FilePathUtils.joinZipPathSegments error on windows #1592

Closed
Kr0nox opened this issue Feb 21, 2024 · 1 comment
Closed

FilePathUtils.joinZipPathSegments error on windows #1592

Kr0nox opened this issue Feb 21, 2024 · 1 comment
Assignees
@TwoOfTwelve
Labels
bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change

Comments

@Kr0nox
Copy link
Member

Kr0nox commented Feb 21, 2024

On windows the joinZipPathSegments of the FilePathUtils does not work properly on windows. This is because files are not seperated by /, but rather by \. A hotfix was provided in #1591, but a proper solution is needed for the future.
@tsaglam tsaglam added bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change labels Feb 21, 2024
@TwoOfTwelve TwoOfTwelve mentioned this issue Feb 24, 2024
Merged
@TwoOfTwelve TwoOfTwelve self-assigned this Feb 26, 2024
@tsaglam
Copy link
Member

tsaglam commented Mar 13, 2024

Closed by #1609.

@tsaglam tsaglam closed this as completed Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TwoOfTwelve TwoOfTwelve

Labels
bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tsaglam @Kr0nox @TwoOfTwelve