-
-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: refactor headers to use same code #725
Conversation
✅ Deploy Preview for hugo-congo ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
This pull request has been automatically marked as stale because it has not had any recent activity. |
Sorry for leaving this PR around so long but one of the things I've been contemplating with this is whether this change is too simple. For instance, I look at both the hamburger and basic content files and there's still a lot of repetition between the two. One of the goals I have in mind for this issue is to extract a whole bunch of the repetition like the appearance switcher and search into separate partials so that it's super easy to reuse them across a range of header templates. This would also make it even easier for people to be able to override just one component of the header without having to make customisations to the entire block. |
Will continue again based on the current dev branch once I have more time 👍 |
hybrid/basic/hamburger
contentCloses #721