Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

device health status is incomplete #210

Closed
karenetheridge opened this issue Apr 21, 2020 · 0 comments · Fixed by #305
Closed

device health status is incomplete #210

karenetheridge opened this issue Apr 21, 2020 · 0 comments · Fixed by #305
Assignees
Milestone

Comments

@karenetheridge
Copy link
Contributor

In src/views/DeviceInspector/OverviewTab.vue in the release/v4 branch, I see a conditional on device.health (to dispay "Failing Validation", "Passing Validation" etc), but the only values that are checked are "fail", "pass" and "unknown". There is a fourth status, "error", which should also be checked and displayed. (This enum is defined in the json schemas available in the documentation and via the GET /schema/... endpoints.)

Note that sometimes health could be "error" when the most recent validation_state+validation_result records show a pass result -- this is because not all error conditions are caused by validation failures.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants