You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I saw a comment on another discussion about supporting too many workflows, but I thought it would make more sense to start a new discussion.
I was thinking about this, and was going to tackle it before it saw your comment.
Essentially, I was going to add a script named run.py to the root directory. It would act as a main entry point to the all of the scripts in the src folder, but it would also allow consolidation of some of the common processing of command line arguments.
This would allow a user with a full python stack installed locally to just run the script.
I was then going to convert run.bat and run.sh to just be thin shells that check to see if the docker image exists, create it if it doesn't, and then run run.py in a container. Because run.py would be doing all the heavy lifting, run.bat/run.sh could just pass command line arguments straight to run.py, simplifying the docker scripts and making them much easier to maintain.
I'm not sure how the Makefile fits into the various workflows, but at first glance it seems like it would also be a simple change.
I can give this a go and submit a PR if you think this is a path you'd like to pursue. But I wanted to start the discussion before I dove in.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
I saw a comment on another discussion about supporting too many workflows, but I thought it would make more sense to start a new discussion.
I was thinking about this, and was going to tackle it before it saw your comment.
Essentially, I was going to add a script named run.py to the root directory. It would act as a main entry point to the all of the scripts in the src folder, but it would also allow consolidation of some of the common processing of command line arguments.
This would allow a user with a full python stack installed locally to just run the script.
I was then going to convert run.bat and run.sh to just be thin shells that check to see if the docker image exists, create it if it doesn't, and then run run.py in a container. Because run.py would be doing all the heavy lifting, run.bat/run.sh could just pass command line arguments straight to run.py, simplifying the docker scripts and making them much easier to maintain.
I'm not sure how the Makefile fits into the various workflows, but at first glance it seems like it would also be a simple change.
I can give this a go and submit a PR if you think this is a path you'd like to pursue. But I wanted to start the discussion before I dove in.
Beta Was this translation helpful? Give feedback.
All reactions