Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enterprise / private deployments support? #2

Open
ArturGajowy opened this issue Jan 30, 2018 · 2 comments
Open

Enterprise / private deployments support? #2

ArturGajowy opened this issue Jan 30, 2018 · 2 comments

Comments

@ArturGajowy
Copy link

Browser name: any

Browser version: n/a

OctoPermalinker version: latest

URL number where issue occurs: everywhere

Expected behavior: The plugin should work on private/enterprise deployments of gitbub

Actual behavior: It doesn't

https://github.com/josephfrazier/octopermalinker/blob/master/.editorconfig#L10

here

@ArturGajowy
Copy link
Author

I also pasted two inks to this repo and they weren't permalinked despite the addon is on. Let's try in a comment:
https://github.com/josephfrazier/octopermalinker/blob/master/.editorconfig#L10

here

Nopes :(

@josephfrazier
Copy link
Owner

Hi @ArturGajowy, thanks for the reports!

The plugin should work on private/enterprise deployments of gitbub

This would be a great feature, but I don't have time to add it now. I'd certainly be willing to consider a pull request that adds such an option, though, so if anyone's willing to work on it, let's talk more about the details. This extension was forked from OctoLinker, which has had the same feature proposed in OctoLinker/OctoLinker#75. OctoLinker/OctoLinker#183 shows one attempt at adding support, but it didn't work out, for reasons shown in the comments there. However, it looks like Octotree supports enterprise URLs, so that might be a good place to start looking for implementation details.

I also pasted two inks to this repo and they weren't permalinked despite the addon is on. Let's try in a comment:

I'm not able to reproduce this, as the links appear for me. Can you try again with a build from source using a clean instance of Chrome/Firefox, as outlined in the Developer Guide Quick Start?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants