Fix RCS1084 #1085
Merged
Fix RCS1084 #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josefpihrt
requested changes
May 18, 2023
src/Tests/Analyzers.Tests/RCS1084UseCoalesceExpressionInsteadOfConditionalExpressionTests.cs
Outdated
Show resolved
Hide resolved
src/Analyzers.CodeFixes/CSharp/Refactorings/SimplifyNullCheckRefactoring.cs
Outdated
Show resolved
Hide resolved
src/Analyzers.CodeFixes/CSharp/Refactorings/SimplifyNullCheckRefactoring.cs
Outdated
Show resolved
Hide resolved
josefpihrt
approved these changes
Jun 1, 2023
Haarmees
pushed a commit
to Haarmees/Roslynator
that referenced
this pull request
Oct 30, 2023
Co-authored-by: Josef Pihrt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the types of a and b are polymorphic and we wish to null coalesce them (
a??b), then we must cast the LHS of the null coalesce operator to the base type, or the compiler will throw an error (i.e. (Base?)a??b https://stackoverflow.com/questions/25240564/polymorphic-null-coalescing-operatorA complete example is given in the test code below.