Skip to content
This repository has been archived by the owner on Aug 12, 2023. It is now read-only.

Allow toggling source availability #337

Closed
1 task done
jose-elias-alvarez opened this issue Nov 12, 2021 · 1 comment
Closed
1 task done

Allow toggling source availability #337

jose-elias-alvarez opened this issue Nov 12, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@jose-elias-alvarez
Copy link
Owner

Issues

  • I have checked existing issues and there are no existing ones with the same request.

Feature description

Mentioned by @David-Else in #332. We can reuse the query mechanism from the deregister API to enable / disable / toggle source availability.

Help

Yes

Implementation help

Doing this at the source level is simple. I imagine users would want diagnostics to be hidden when a source is disabled (which is as good a reason as any to move to the new diagnostics API) and regenerated when a source is enabled, for which we can maybe reuse this logic.

@jose-elias-alvarez
Copy link
Owner Author

f1e69d8 adds a basic version of this. I didn't implement regenerating diagnostics, which would most likely require a synthetic notification, but I'd welcome a PR for it if anyone is interested.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant