Improve performance of max and min

[pseudosavant]

Using Math.max.apply(null, array) is ~100x faster on large arrays than the current max and min implementation.

Note that Chrome has a limit of ~100k arguments when using .apply so arrays larger than 100k values need to be done in batches. See here.

[Yaffle]

but Math.max converts all arguments to numbers...
Also why do you think, native Math.max can be faster?

[pseudosavant]

Check out this: http://jsbin.com/vativ/1/edit?js,console. FWIW, running that on my phone (what I'm on right now) is actually ~200x faster.

I've tried quite a few ways of doing this and using Math.max is easily the fastest. The code to do it in math.js wouldn't be near as elegant as the current version you have (nice use of closures) but it's not too bad. I'm thinking of coding it up myself so look for a pull request.

BTW, this looks like a great library. High quality code, good documentation. That's why I'm actually interested in contributing.

Paul

---

From: Viktormailto:[email protected]
Sent: ‎9/‎6/‎2014 9:27 PM
To: josdejong/mathjsmailto:[email protected]
Cc: Paul Ellismailto:[email protected]
Subject: Re: [mathjs] Improve performance of max and min (#212)

but Math.max converts all arguments to numbers...
Also why do you think, native Math.max can be faster?

---

Reply to this email directly or view it on GitHub:
#212 (comment)

[josdejong]

math.js is slower because it's doing type-checking of all array values.

Performance improvements for matrix operations in general is on the radar, see for example #275. Is it ok with you to close this issue?