You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
This should probably be quite a bit faster for doing many operations like comparison kernels etc.
I think there is also some potential for simplifying code, as some (unsafe) code now tries to create u64 chunks (see #578 , there are other many other places in the code doing this, i.e. bitwise ops).
Having the bitmap use u64 instead of u8 would reduce the need to do those conversions and also speed up some parts which work at u8 at a time (e.g. comparison kernels currently use u8) without the need to
I agree that it is worth trying out. I think that bitvec's semantics is different from arrow on a u64, though. Specifically, on a u64, the indexes of bits here need to be
Another option might be to create a safe API that allows working on slices of &[usize]. For instance the unsafe part could be isolated by a fn split_by_alignment<usize> -> (&[u8], &[usize], &[u8]).
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This should probably be quite a bit faster for doing many operations like comparison kernels etc.
I think there is also some potential for simplifying code, as some (unsafe) code now tries to create
u64
chunks (see #578 , there are other many other places in the code doing this, i.e. bitwise ops).Having the bitmap use
u64
instead ofu8
would reduce the need to do those conversions and also speed up some parts which work atu8
at a time (e.g. comparison kernels currently useu8
) without the need toSome references:
usize
by defaultIt would be quite an invasive change so I think it's good to discuss potential trade-offs first.
The text was updated successfully, but these errors were encountered: