Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

arrow2::compute::arithmetics::negate will panic if use i32::MIN #465

Closed
yjhmelody opened this issue Sep 29, 2021 · 1 comment · Fixed by #506
Closed

arrow2::compute::arithmetics::negate will panic if use i32::MIN #465

yjhmelody opened this issue Sep 29, 2021 · 1 comment · Fixed by #506
Labels
feature A new feature no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog

Comments

@yjhmelody
Copy link
Contributor

The negate of MIN is not existed. Should it be checked?
@jorgecarleitao
Copy link
Owner

jorgecarleitao commented Oct 8, 2021 •
edited
Loading

I would say we should follow rust's semantics, which panics in this case. Maybe adding checked_neg like we have for add, div, etc?

@yjhmelody yjhmelody mentioned this issue Oct 8, 2021
Merged
@jorgecarleitao jorgecarleitao added feature A new feature no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog labels Oct 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature A new feature no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added checked_negate and wrapping_negate for PrimitiveArray yjhmelody/arrow2
2 participants
@jorgecarleitao @yjhmelody