Support conditional test

[edouard-lopez]

Pure support several version of fish (2.5 to 3.0.0). However some of our tests are only meaningful on some version of the platform.

To manage this we wrap those tests in a if…end block, e.g. _pure_prompt_ssh_host.test.fish:

if fish_version_at_least '3.0.0'
test "_pure_prompt_ssh_host: use native \$hostname"
    (
        set pure_color_ssh_host (set_color grey)

        _pure_prompt_ssh_host > /dev/null
    ) $status -eq 0
end
end

This work as expected but look messy, a decorator would be a lot more elegant, e.g.:

# fish_version_at_least 3.0.0
test "_pure_prompt_ssh_host: use native \$hostname"
    …
end

[jorgebucaran]

@edouard-lopez Is this related to #34?

[edouard-lopez]

Nope, but that a feature request for next release 😛

[jorgebucaran]

@edouard-lopez Sure it isn't related? Why can't you do this:

if fish_version_at_least '3.0.0'
  test "_pure_prompt_ssh_host: use native \$hostname"
    (
        set pure_color_ssh_host (set_color grey)

        _pure_prompt_ssh_host > /dev/null
    ) $status -eq 0
  end
end

[edouard-lopez]

That's what I do but I would prefer a decorator

[jorgebucaran]

@edouard-lopez I think I get it now. You are asking for a pre-processor feature to sieve out tests if they are above or below a specific fish version (or based on the status code after running some arbitrary function) and the proposed syntax is a comment.

[edouard-lopez]

Correct.

[jorgebucaran]

@edouard-lopez I don't think writing conditional tests like are commonplace enough to justify adding a new feature to Fishtape. Instead of adding a special feature for this, I suggest we use regular fish code:

if fish_version_equals_or_is_above 3.0.0
    @test "something" (
        actual operator expected
    )
end