Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache hash should not use the config's absolute paths #199

Open
rogerntan opened this issue Jun 12, 2015 · 0 comments
Open

Cache hash should not use the config's absolute paths #199

rogerntan opened this issue Jun 12, 2015 · 0 comments

Comments

@rogerntan
Copy link

We use the cache busting token functionality to ensure that new sprites are different. I just noticed that we were generating new sprites (and uploading them) even though nothing had changed.

It turns out that the image contents themselves are the same, but the configuration dictionaries differed. Each developer has a different repo path, and because some of the file paths in the configuration are absolute paths, the resultant hashes differed.

For us, we don't need the config to be an input to the hashing function, though I can see why it might be desirable. Would it be possible to use relative paths for the hashing function, or maybe a command line option to opt out of using the configuration dictionary for generating a hash?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant