Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support __array_ufunc__ in lmo.l_(loc|scale|variation|skew|kurtosis) #184

Open
jorenham opened this issue Mar 29, 2024 · 0 comments
Open
Assignees
Labels
contrib Integration with 3rd party packages enhancement New feature or request
Milestone

Comments

@jorenham
Copy link
Owner

jorenham commented Mar 29, 2024

Currently, these always return a np.ndarray, even when the input is an e.g. pd.Series.

By making these functions aware of the potential __array_ufunc__ or __array_function__ methods, it can automatically "lift" itself, so that the types of ufunc-aware instances can pass-though.

It's probably best to use np.frompyfunc for this.

Note that this will require additional @overload's.

@jorenham jorenham added the contrib Integration with 3rd party packages label Mar 29, 2024
@jorenham jorenham changed the title Make lmo.l_(loc|scale|skew|kurtosis) behave like ufuncs Turn lmo.l_(loc|scale|skew|kurtosis) into ufuncs Mar 29, 2024
@jorenham jorenham changed the title Turn lmo.l_(loc|scale|skew|kurtosis) into ufuncs Make lmo.l_(loc|scale|skew|kurtosis) aware of __array_ufunc__ Mar 29, 2024
@jorenham jorenham changed the title Make lmo.l_(loc|scale|skew|kurtosis) aware of __array_ufunc__ Support __array_ufunc__ in lmo.l_(loc|scale|variation|skew|kurtosis) Mar 29, 2024
@jorenham jorenham added this to the v0.14.0 milestone Mar 29, 2024
@jorenham jorenham added the enhancement New feature or request label Mar 29, 2024
@jorenham jorenham self-assigned this Mar 29, 2024
@jorenham jorenham modified the milestones: v0.14.0, v1.0.0 May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contrib Integration with 3rd party packages enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant