Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Select bit in "Interpretation" and jump to them in "analysis" #443

Closed
Nesos-ita opened this issue May 29, 2018 · 6 comments

Comments

@Nesos-ita
Copy link

Nesos-ita commented May 29, 2018

signal that i'm analyzing is visible here (#338):
img
I have a signal compossed by a preamble, a pause, sync+short pause+data, everything expect the preamble repeated equal three times.
I'd like to analyze it, so i recorded multiple messages with different temperatures and humidity values.
each recording is one trasmission/one pair of temp+hum
Problem: program split the message in multiple parts making the result simply useless.
Not-so-good-solution: disable message break on pause (set pause threshold =0)
new problem: in analysis i see a looong ammount of 0 since pause has been removed
new imperfect solution: use ZeroHide plugin, now everything is good, i only need to add labels like preamble, sync1, data1, sync2, data2, sync3, data3; and after set as visible only one data label (the fact that preamble and sync is always equal has been checked by hand long time ago)
problem: pauses have been removed so i have no idea where the sync start and end.
possible solution: this feature request :) i mark the sync part, jump to it in analysis, it will mark the whole sync so i see where it start and end and add a new label.
It would be nicer if there is a way to keep the pause in interpretation and also in analysis, but don't split the message on multiple lines!
some ideas:

  • in anaysis add a "P" between all those 0 and 1 when there ia a pause
  • in analysis make a bold vertical line | that indicate where the pause is

all without going to new line
I LOVE THIS PROGRAM <3
it automate so many tasks so that the only thing that i have to do more than once is recording signals :)
if you find a way to keep the pause visible and not split on multiple lines so that i can add labels easily it will be perfect :)

@jopohl
Copy link
Owner

jopohl commented May 29, 2018

Did you try to set the pause threshold to 16 instead of 0? As the pause between actual messages is much greater than between sync and data I see no reason to disable message breaking entirely with pause threshold 0.

@Nesos-ita
Copy link
Author

Nesos-ita commented May 29, 2018

i could and it will probably work but then i will have 4 messages (instead of 7):

  • preamble
  • sync + data (repeated three times)

The problem is that i will have preamble and sync+data and there is no point in comparing them, also i could not set a label as preamble and other as sync+data because they will be on the same line (again split message problem).
i could also cut away the preamble or any part except data but this means editing N signals and is also problematic if i have to replay it after.
If the signal is made in that way i would like to keep every part of it, eventually mark the first part as preamble and hide that label but not deleting it.

@jopohl
Copy link
Owner

jopohl commented May 29, 2018

Ah I see...well at least this will get the preambles into seperate messages so you could hide them in Analysis.

It it also possible to deal with the labeling problem using message types. Here is an example:
bildschirmfoto_2018-05-29_10-12-28

Message 2 has a different message type than the other messages so it can be labeled differently. You can add a new message type using the + button and assign a message type to a message using the context menu in Analysis table. You can even automate this assigning by creating a rule for the message type using the button left to the "+". This way you could, e.g, assign a "preamble" message type to all preamble messages.

Btw thanks for taking your time to make such detailed issues, it really helps fixing bugs quickly. 👍

@Nesos-ita
Copy link
Author

Nesos-ita commented May 29, 2018

Btw thanks for taking your time to make such detailed issues, it really helps fixing bugs quickly. +1

Happy to be useful ^_^
i'll try message type this evening, now i'm not at home

@Nesos-ita
Copy link
Author

Nesos-ita commented May 29, 2018

I have tried using message types as suggested, and found a bug, opened here: #451
I think that multiple message types, labels, automatic label assign and longer pause detection solves all the problems described here* (the program is now usable also if it split a single message on multiple lines)
I think you can close this now :)
*except that multiple message types is bugged

@jopohl
Copy link
Owner

jopohl commented May 29, 2018

Awesome. glad it works for you. 👍

@jopohl jopohl closed this as completed May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants