From 22b4fc96353ed41dc2300118ccae1f5b1dba05f2 Mon Sep 17 00:00:00 2001
From: Johannes Pohl <Johannes.Pohl90@gmail.com>
Date: Sun, 24 Feb 2019 15:30:43 +0100
Subject: [PATCH] Fix InnoSetup Version (#621)

---
 data/azure-pipelines.yml | 4 +---
 data/inno.iss            | 2 +-
 data/release.py          | 7 +++++--
 src/urh/version.py       | 6 +++++-
 4 files changed, 12 insertions(+), 7 deletions(-)

diff --git a/data/azure-pipelines.yml b/data/azure-pipelines.yml
index 6e024cbd52..6d4c52cbcd 100644
--- a/data/azure-pipelines.yml
+++ b/data/azure-pipelines.yml
@@ -141,9 +141,7 @@ jobs:
     displayName: "Run PyInstaller"
 
   - script: |
-      choco install innosetup
-      python src/urh/version.py > C:\urh_version.txt
-      set /p URHVERSION=<C:\urh_version.txt
+      for /f %%i in ('python src/urh/version.py') do set URHVERSION=%%i
       iscc /dMyAppVersion=%URHVERSION% /dArch=$(python.arch) data/inno.iss
     condition: eq(variables['python.version'], '3.7')
     displayName: "Create setup.exe"
diff --git a/data/inno.iss b/data/inno.iss
index 36437bc0bb..d3263ab6d9 100644
--- a/data/inno.iss
+++ b/data/inno.iss
@@ -16,7 +16,7 @@ DefaultDirName={pf}\Universal Radio Hacker
 DisableProgramGroupPage=yes
 LicenseFile=..\LICENSE
 OutputDir=..\dist
-OutputBaseFilename=Universal.Radio.Hacker-{#Arch}
+OutputBaseFilename=Universal.Radio.Hacker-{#MyAppVersion}-{#Arch}
 Compression=lzma2/ultra
 SolidCompression=yes
 
diff --git a/data/release.py b/data/release.py
index 72e3365df8..79d8d66be0 100644
--- a/data/release.py
+++ b/data/release.py
@@ -1,3 +1,4 @@
+import fileinput
 import os
 import shutil
 import sys
@@ -46,8 +47,10 @@ def release():
     numbers[-1] = str(int(numbers[-1]) + 1)
     cur_version = ".".join(numbers)
 
-    with open(version_file, "w") as f:
-        f.write('VERSION = "{0}" \n'.format(cur_version))
+    for line in fileinput.input(version_file, inplace=True):
+        if line.startswith("VERSION"):
+            line = 'VERSION = "{0}" \n'.format(cur_version)
+        print(line, end='')
 
     # Publish new version number
     call(["git", "add", version_file])
diff --git a/src/urh/version.py b/src/urh/version.py
index 3f30d1eb4f..b0a8c9e782 100644
--- a/src/urh/version.py
+++ b/src/urh/version.py
@@ -1 +1,5 @@
-VERSION = "2.5.6" 
+VERSION = "2.5.6"
+
+if __name__ == '__main__':
+    # To read out version easy on command line for InnoSetup
+    print(VERSION)