Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Upgrade gradle's required version #32

Closed
henryx opened this issue Apr 28, 2023 · 3 comments
Closed

[IMPROVEMENT] Upgrade gradle's required version #32

henryx opened this issue Apr 28, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@henryx
Copy link
Collaborator

henryx commented Apr 28, 2023

At the moment, the project is built using Gradle 5.6.4. According to this issue, this version cannot be used with Java greather than 11. This is a problem because it doesn't allow updating the Java version used for project development. therefore it is necessary to carry out the activities necessary to allow Gradle to be updated, in particular by rewriting the deprecated parts in the new versions. An alternative is change the build system (with Maven or other), but it is preferrable to adopt this way as extrema ration

@henryx henryx added the enhancement New feature or request label Apr 28, 2023
@henryx henryx mentioned this issue Apr 28, 2023
2 tasks
@kLeZ
Copy link

kLeZ commented Apr 29, 2023

Trying to help on this. Just forked.

@HomeOfTheWizard
Copy link

HomeOfTheWizard commented Jun 8, 2023

Hi @henryx ,

I have created the following PR #39, a minimum work just to unblock #22.

Tested the unitTest all is working, however I realized that 3 integrationTests don't pass with the latest version of the Vault image because the API returns 204 instead of 200.
I did not change the tests in case you use a specific version of the image in your CI environment.

io.github.jopenlibs.vault.api.AuthBackendPkiTests > testRevocation FAILED
    junit.framework.AssertionFailedError at AuthBackendPkiTests.java:168
io.github.jopenlibs.vault.api.AuthBackendPkiTests > testIssueCredential FAILED
    junit.framework.AssertionFailedError at AuthBackendPkiTests.java:100
io.github.jopenlibs.vault.api.AuthBackendPkiTests > testIssueCredentialWithCsr FAILED
    junit.framework.AssertionFailedError at AuthBackendPkiTests.java:141

But I think we must fix them and alway run the tests with the latest image of Vault.

@kLeZ please continue feel free to continue your work in case you see other improvements or changes related to the new APIs of gradle. I am new to gradle so I may have missed some things.

@henryx
Copy link
Collaborator Author

henryx commented Jun 15, 2023

@HomeOfTheWizard Thank you so much for you PR, I've merged it in mainline before check the CI result

@henryx henryx closed this as completed Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants