Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] Deprecating WinCache for Joomla 5.0 #2377

Closed
jgerman-bot opened this issue Apr 2, 2022 · 0 comments · Fixed by #2459
Closed

[4.2] Deprecating WinCache for Joomla 5.0 #2377

jgerman-bot opened this issue Apr 2, 2022 · 0 comments · Fixed by #2459

Comments

@jgerman-bot
Copy link

New language relevant PR in upstream repo: joomla/joomla-cms#37453 Here are the upstream changes:

Click to expand the diff!
diff --git a/administrator/language/en-GB/lib_joomla.ini b/administrator/language/en-GB/lib_joomla.ini
index 3b9134ff5890..a0b9eda76f12 100644
--- a/administrator/language/en-GB/lib_joomla.ini
+++ b/administrator/language/en-GB/lib_joomla.ini
@@ -347,7 +347,7 @@ JLIB_FORM_VALUE_CACHE_APCU="APC User Cache"
 JLIB_FORM_VALUE_CACHE_FILE="File"
 JLIB_FORM_VALUE_CACHE_MEMCACHED="Memcached (Experimental)"
 JLIB_FORM_VALUE_CACHE_REDIS="Redis"
-JLIB_FORM_VALUE_CACHE_WINCACHE="Windows Cache"
+JLIB_FORM_VALUE_CACHE_WINCACHE="Windows Cache (deprecated)"
 JLIB_FORM_VALUE_FROM_TEMPLATE="From Template"
 JLIB_FORM_VALUE_INHERITED="Inherited"
 JLIB_FORM_VALUE_SESSION_APCU="APC User Cache"
@@ -355,7 +355,7 @@ JLIB_FORM_VALUE_SESSION_DATABASE="Database"
 JLIB_FORM_VALUE_SESSION_FILESYSTEM="Filesystem"
 JLIB_FORM_VALUE_SESSION_MEMCACHED="Memcached (Experimental)"
 JLIB_FORM_VALUE_SESSION_REDIS="Redis"
-JLIB_FORM_VALUE_SESSION_WINCACHE="Windows Cache"
+JLIB_FORM_VALUE_SESSION_WINCACHE="Windows Cache (deprecated)"
 JLIB_FORM_VALUE_TIMEZONE_UTC="Universal Time, Coordinated (UTC)"
 JLIB_HTML_ACCESS_MODIFY_DESC_CAPTION_ACL="ACL"
 JLIB_HTML_ACCESS_MODIFY_DESC_CAPTION_TABLE="Table"
diff --git a/language/en-GB/lib_joomla.ini b/language/en-GB/lib_joomla.ini
index ffde173aad09..e02088402799 100644
--- a/language/en-GB/lib_joomla.ini
+++ b/language/en-GB/lib_joomla.ini
@@ -346,7 +346,7 @@ JLIB_FORM_VALUE_CACHE_APCU="APC User Cache"
 JLIB_FORM_VALUE_CACHE_FILE="File"
 JLIB_FORM_VALUE_CACHE_MEMCACHED="Memcached (Experimental)"
 JLIB_FORM_VALUE_CACHE_REDIS="Redis"
-JLIB_FORM_VALUE_CACHE_WINCACHE="Windows Cache"
+JLIB_FORM_VALUE_CACHE_WINCACHE="Windows Cache (deprecated)"
 JLIB_FORM_VALUE_FROM_TEMPLATE="From Template"
 JLIB_FORM_VALUE_INHERITED="Inherited"
 JLIB_FORM_VALUE_SESSION_APCU="APC User Cache"
@@ -354,7 +354,7 @@ JLIB_FORM_VALUE_SESSION_DATABASE="Database"
 JLIB_FORM_VALUE_SESSION_FILESYSTEM="Filesystem"
 JLIB_FORM_VALUE_SESSION_MEMCACHED="Memcached (Experimental)"
 JLIB_FORM_VALUE_SESSION_REDIS="Redis"
-JLIB_FORM_VALUE_SESSION_WINCACHE="Windows Cache"
+JLIB_FORM_VALUE_SESSION_WINCACHE="Windows Cache (deprecated)"
 JLIB_FORM_VALUE_TIMEZONE_UTC="Universal Time, Coordinated (UTC)"
 JLIB_HTML_ACCESS_MODIFY_DESC_CAPTION_ACL="ACL"
 JLIB_HTML_ACCESS_MODIFY_DESC_CAPTION_TABLE="Table"
diff --git a/libraries/src/Cache/Storage/WincacheStorage.php b/libraries/src/Cache/Storage/WincacheStorage.php
index 9af3bf335c70..928ab4cfc753 100644
--- a/libraries/src/Cache/Storage/WincacheStorage.php
+++ b/libraries/src/Cache/Storage/WincacheStorage.php
@@ -15,8 +15,9 @@
 /**
  * WinCache cache storage handler
  *
- * @link   https://www.php.net/manual/en/book.wincache.php
- * @since  1.7.0
+ * @link        https://www.php.net/manual/en/book.wincache.php
+ * @since       1.7.0
+ * @deprecated  5.0 WinCache is abandoned and not supported from PHP 8 onwards
  */
 class WincacheStorage extends CacheStorage
 {
@@ -28,7 +29,8 @@ class WincacheStorage extends CacheStorage
 	 *
 	 * @return  boolean
 	 *
-	 * @since   3.7.0
+	 * @since       3.7.0
+	 * @deprecated  5.0
 	 */
 	public function contains($id, $group)
 	{
@@ -44,7 +46,8 @@ public function contains($id, $group)
 	 *
 	 * @return  mixed  Boolean false on failure or a cached data object
 	 *
-	 * @since   1.7.0
+	 * @since       1.7.0
+	 * @deprecated  5.0
 	 */
 	public function get($id, $group, $checkTime = true)
 	{
@@ -56,7 +59,8 @@ public function get($id, $group, $checkTime = true)
 	 *
 	 * @return  mixed  Boolean false on failure or a cached data object
 	 *
-	 * @since   1.7.0
+	 * @since       1.7.0
+	 * @deprecated  5.0
 	 */
 	public function getAll()
 	{
@@ -109,7 +113,8 @@ public function getAll()
 	 *
 	 * @return  boolean
 	 *
-	 * @since   1.7.0
+	 * @since       1.7.0
+	 * @deprecated  5.0
 	 */
 	public function store($id, $group, $data)
 	{
@@ -124,7 +129,8 @@ public function store($id, $group, $data)
 	 *
 	 * @return  boolean
 	 *
-	 * @since   1.7.0
+	 * @since       1.7.0
+	 * @deprecated  5.0
 	 */
 	public function remove($id, $group)
 	{
@@ -142,7 +148,8 @@ public function remove($id, $group)
 	 *
 	 * @return  boolean
 	 *
-	 * @since   1.7.0
+	 * @since       1.7.0
+	 * @deprecated  5.0
 	 */
 	public function clean($group, $mode = null)
 	{
@@ -166,7 +173,8 @@ public function clean($group, $mode = null)
 	 *
 	 * @return  boolean
 	 *
-	 * @since   1.7.0
+	 * @since       1.7.0
+	 * @deprecated  5.0
 	 */
 	public function gc()
 	{
@@ -190,7 +198,8 @@ public function gc()
 	 *
 	 * @return  boolean
 	 *
-	 * @since   3.0.0
+	 * @since       3.0.0
+	 * @deprecated  5.0
 	 */
 	public static function isSupported()
 	{
diff --git a/libraries/src/Session/SessionFactory.php b/libraries/src/Session/SessionFactory.php
index deebd4df5c98..657dbeccc606 100644
--- a/libraries/src/Session/SessionFactory.php
+++ b/libraries/src/Session/SessionFactory.php
@@ -137,6 +137,7 @@ public function createSessionHandler(array $options): HandlerInterface
 				return new Handler\RedisHandler($redis, ['ttl' => $options['expire']]);
 
 			case 'wincache':
+				// @TODO Remove WinCache with Joomla 5.0
 				if (!Handler\WincacheHandler::isSupported())
 				{
 					throw new RuntimeException('Wincache is not supported on this system.');
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants