Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark Mode Compare Versions [a11y] #44293

Closed
brianteeman opened this issue Oct 17, 2024 · 1 comment · May be fixed by #44534
Closed

Dark Mode Compare Versions [a11y] #44293

brianteeman opened this issue Oct 17, 2024 · 1 comment · May be fixed by #44534
Labels
bug Dark Mode good first issue Small tasks with clear documentation about how and in which place you need to fix things in. No Code Attached Yet

Comments

@brianteeman
Copy link
Contributor

Steps to reproduce the issue

Create two versions of an article and compare them

Expected result

Highlighted text takes into account of dark mode and adjusts the colours accordingly so that it is readable and accessible. It should be enough to just change the font color and leave the colours as is.

Actual result

Image

Additional comments

The relevant file to update is build\media_source\com_contenthistory\js\admin-compare-compare.es6.js
@Quy Quy added the Dark Mode label Oct 17, 2024
@Quy Quy added the bug label Nov 7, 2024
@wilsonge wilsonge added the good first issue Small tasks with clear documentation about how and in which place you need to fix things in. label Nov 10, 2024
@SheikhZaeem SheikhZaeem mentioned this issue Nov 26, 2024
Open
@richard67
Copy link
Member

Closing as having a pull request. Please test #44534 . Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Dark Mode good first issue Small tasks with clear documentation about how and in which place you need to fix things in. No Code Attached Yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve dark mode readability in compare view SheikhZaeem/joomla-cms
5 participants
@Quy @brianteeman @wilsonge @richard67 @joomla-cms-bot