-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2.1] fontawsome.css has no font-face to load the font files #44451
Comments
According to templates/cassiopeia/joomla.asset.json the file system/joomla-fontawesome.min.css is loaded The compiled file can be found in /media/system/css/joomla-fontawesome.min.css in this file I can find a reference to the font-face... at least on my machine.
this is what I see on my machine. |
In my component I'm building I want to use the vanilla fontawsome.css from the media/vendor folder. And right now it cannot be used as there is no font files loaded in it. That is why I am questioning if it is meant to be used as standalone or should be compiled from the scss files. |
After installation of Joomla the fonts (ttf, woff2) can be found in media/vendor/font-awesome-free/webfonts. |
Yeah, that a bug. default fontawesome.css does not include woff2. Joomla have to provide |
Note: you can use joomla-cms/templates/cassiopeia/joomla.asset.json Lines 104 to 108 in e6518fb
In your template, the same as joomla cassiopeia do, which also includes some classes for core |
I think, the proper way here would be to build what you need based on the supplied scss files: |
Yes I know, but that still don't change the main issue that the vendor/fontawesome-free is not compiled with font-faces. But if that is by design then it all good. @Fedik as you pointed out maybe just create a fontawsome-all.scss in the folder that includes all files. This should be compiled on Joomla build, and now we have both fontawsome.css broken and fontawsome-all.css that works. |
Yes, kind of that. But I think it is enough to replace fontawsome.css to fontawsome-all.css, beacause fontawsome.css as it is now is useless anyway. |
When working with Cassiopeia the file media/system/css/joomla-fontawesome.css is loaded. This file does contain The file media/vendor/fontawesome-free/css/fontawesome(.min).css is created by compiling just a part of the file mentioned above. commit ffa3108 by @laoneo |
Steps to reproduce the issue
Don't know if this is a bug or how it should work. But the fontawesome.css in the vendor folder has no font-face for the font files loaded.
Guess because brands.scss, regular.scss and solid.scss is not compiled into it.
Is this vendor library only supposed to be compiled into your own library or be able to used as standalone?
Expected result
Font awesome icons are loaded when using the CSS.
Actual result
The font files are not loaded.
System information (as much as possible)
Joomla 5.2.1
Additional comments
The text was updated successfully, but these errors were encountered: