Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4b6] Disable SEF Plugin breaks default template logo url #31989

Closed
PhilETaylor opened this issue Jan 10, 2021 · 10 comments
Closed

[4b6] Disable SEF Plugin breaks default template logo url #31989

PhilETaylor opened this issue Jan 10, 2021 · 10 comments

Comments

@PhilETaylor
Copy link
Contributor

Steps to reproduce the issue

Joomla 4 beta 6 - install the "Testing Sample Data"
Visit frontend, click a menu link in the left menu to get to an article
Note that the CASSIOPEIA logo (white text on blue background) is present

In Joomla Admin disable the "System - SEF" plugin

Refresh your article page on the frontend

Note the logo is now a broken image

Expected result

Regardless of SEF settings expectation is to see the logo

Screenshot 2021-01-10 at 17 42 09

Image logo url is http://127.0.0.1:4444/templates/cassiopeia/images/logo.svg

Actual result

Note that joomal4b6 shown in this screenshot is my "Site name" in Joomla Global Config and is not related to the SEF issue.

Screenshot 2021-01-10 at 17 43 07

Image logo URL is http://127.0.0.1:4444/index.php/templates/cassiopeia/images/logo.svg

System information (as much as possible)

Additional comments

@PhilETaylor PhilETaylor changed the title [4b6] Disable SEF Plugin breaks default template logo [4b6] Disable SEF Plugin breaks default template logo url Jan 10, 2021
@brianteeman
Copy link
Contributor

Unable to replicate

image

image

image

@PhilETaylor

This comment was marked as abuse.

@brianteeman
Copy link
Contributor

Correction - it breaks as soon as I go away from the home page

@PhilETaylor

This comment was marked as abuse.

@bembelimen
Copy link
Contributor

The problem is, that the SEF-Plugin is (beside its little SEF changes) more a "fix all the broken things"-plugin. Like all the broken paths because Joomla! <= 3 has a wrong base tag which is removed in Joomla! 4.
So probably we should make this plugin a locked plugin to prevent disabling it (or re-add the base tag again, but in a correct way).

@Hackwar
Copy link
Member

Hackwar commented Mar 17, 2021

There is no correct way to add the base tag. It does not belong into our output.

@ReLater
Copy link
Contributor

ReLater commented Mar 17, 2021

So probably we should make this plugin a locked plugin to prevent disabling it

The ability to disable almost everything in Joomla 4 has been given so that developers can establish their own solutions wherever they want. A big step forward. If we now start to disable the disabling possibility for every extension where something could possibly work wrong, that would be a bad solution. One can not uninstall these extensions anymore in Joomla 4. That should be sufficient.

See also #28563 (comment)
below headline "This is a list of extensions that can be disabled"

@PhilETaylor

This comment was marked as abuse.

@ReLater
Copy link
Contributor

ReLater commented Mar 17, 2021

The image should load regardless of the state of the SEF plugin.

If you disable Joomla's link corrections for image paths? From my point of view that's the well known behavior.

@PhilETaylor

This comment was marked as abuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants