Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Remaining mails to be converted to mail templates #29215

Closed
8 of 15 tasks
richard67 opened this issue May 25, 2020 · 2 comments
Closed
8 of 15 tasks

[4.0] Remaining mails to be converted to mail templates #29215

richard67 opened this issue May 25, 2020 · 2 comments

Comments

@richard67
Copy link
Member

Steps to reproduce the issue

This is just a reminder on the remaining mail types to be converted to mail templates after PR #28722 has been merged.

Expected result

All kinds of mails sent by the core are using mail templates.

Actual result

Done:

To be done:

  • Notification mail from com_actionlogs (administrator\components\com_actionlogs\src\Model\ActionlogModel.php line 174)
  • com_messages notification (administrator\components\com_messages\src\Model\MessageModel.php line 435)
  • com_privacy send export to user (administrator\components\com_privacy\src\Model\ExportModel.php line 240)
  • com_privacy notification about a new request (administrator\components\com_privacy\src\Model\RequestModel.php line 362)
  • com_privacy creating a new request (components\com_privacy\src\Model\RequestModel.php line 188/190 ATTENTION!! HERE IS A BUG! The mail is send twice!)
  • reminder of expiring privacy consent (plugins\system\privacyconsent\privacyconsent.php line 604)
  • User registration (components\com_users\src\Model\RegistrationModel.php line 198, 254, 650, 711)
@richard67
Copy link
Member Author

I'll try to do at least some of the remaining mail templates 'cause I know now how it has to be done.

@richard67
Copy link
Member Author

Closing as having a pull-request which implements all missing mail templates listed in the description. Thanks @Hackwar for that work. Unfortunately I won't be able to test due to health problems (nothing serious, only a bit painful). When I'm fit again and it's still necessary I'll test of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants