Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to set category blog layout override from menu item #18424

Closed
saraheagle opened this issue Oct 27, 2017 · 12 comments
Closed

Ability to set category blog layout override from menu item #18424

saraheagle opened this issue Oct 27, 2017 · 12 comments

Comments

@saraheagle
Copy link

saraheagle commented Oct 27, 2017

Steps to reproduce the issue

Create a new "Category Blog" menu item >> Blog Layout

Expected result

I would like to have a "Choose a layout" dropdown for the blog layout (as opposed to the article layout in the options tab), so the new menu item can use the standard 'Category Blog Layout' menu options.

Actual result

No dropdown, a whole new menu item type with an .xml file needs to be duplicated and amended.

System information (as much as possible)

Joomla 3.8.1

Additional comments

The less code that needs duplicating from Joomla Core the better for keeping a Joomla site updated.

Thank you

@ghost
Copy link

ghost commented Oct 29, 2017

@coolcat-creations looks like a Topic for you.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18424.

@coolcat-creations
Copy link
Contributor

Yes, it's the still pending PR afaik
#16755
@saraheagle please test this :)

@joomla-cms-bot
Copy link

Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/18424

@ghost
Copy link

ghost commented Oct 29, 2017

Thanks for Info, @coolcat-creations, closing Issue as having PR #16755


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18424.

@Sieger66
Copy link
Contributor

Sieger66 commented Nov 12, 2017

I think there is a missunderstanding between saraheagle and coolcat-creations.

PR 16755 and 14802 set the single-articles-details-page-layout from menu item.
This is the view that you see in the frontend after klick on a
article in a catergory -blog (for example):

http://j38.joomla-bugs.de/using-joomla/extensions/components/content-component/article-category-blog.html

view of single-articles-details-page-layout from menu item (for example):

http://j38.joomla-bugs.de/using-joomla/extensions/components/content-component/article-category-blog/17-first-blog-post.html

PR 16755 make this for the article-category-list-menu-item
PR 14802 make this for the article-category-blog-menu-item

but saraheagle want to "Choose a layout" dropdown for the blog layout !

@joomla-cms-bot
Copy link

Set to "open" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/18424

@ghost
Copy link

ghost commented Nov 12, 2017

reopened as stated above.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18424.

@AndySDH
Copy link
Contributor

AndySDH commented Nov 14, 2017

@saraheagle I see the reasoning for your idea, I also brought this up some time ago, but here is what @Bakual had to say on the matter (with a comment on #18150)

The menu items are based on the layouts. It doesn't make sense to select a menuitem for a specific layout and then change that layout in its parameters.
Eg "category blog" and "category list" refer to the same view, but different layouts within that view.

I guess what he says is correct. By implementing this feature, you would be able to create a "Category Blog" menu and change the layout to "Category List"... it wouldn't make too much sense.

@Bakual
Copy link
Contributor

Bakual commented Nov 14, 2017

a whole new menu item type with an .xml file needs to be duplicated and amended.

That's actually the correct way because as said by Andy (and me) the menuitem itself already refers to a layout.
I agree that it isn't that sexy to duplicate the whole XML file. My approach however would be different. See #10548.
My idea in that PR is to specify the bulk of the parameters at the view level, and in the layout XML files you only have the additional parameters relevant for that specific layout. That would probably solve your issue as well if I understood it correct.

@mbabker
Copy link
Contributor

mbabker commented Jul 24, 2018

Unless someone is going to redesign the menu item management workflow, this should be closed as expected behavior. Menu items are based on a specified layout of a specified view in a specified component, the menu item itself isn't designed to have a configurable layout option.

@joomla-cms-bot
Copy link

Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/18424

@ghost
Copy link

ghost commented Jul 24, 2018

Closed as stated above.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18424.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants