Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Button order in modal #16060

Closed
Bakual opened this issue May 16, 2017 · 10 comments
Closed

[UX] Button order in modal #16060

Bakual opened this issue May 16, 2017 · 10 comments

Comments

@Bakual
Copy link
Contributor

Bakual commented May 16, 2017

Steps to reproduce the issue

Create a menu item "SIngle Article" and click the button to "Create" a new article within it.
Or if you have a multilingual site check the association fields in an item, they have similar buttons.

Expected result

The save buttons in the modal are in a consistent order like in regular forms.

Actual result

The buttons are in reversed order

Regular form:

buttonorder2

Modal form:

buttonorder

Additional comments

I don't know if there was a reason to have the buttons in reversed order. I just noticed today and found it a bit unexpected.

@brianteeman
Copy link
Contributor

It could be easily changed to.match but I am not so sure it is needed. In one case they are a toolbar and.in the other they are submit buttons on a form. So to me they are not the same thing so do not have to be consistent but I see no reason to prevent a change either

@Bakual
Copy link
Contributor Author

Bakual commented May 16, 2017

Technically, they're the same, just in different places.
I can do a PR to reverse it but I'm not an UX guy and thus assumed there was a reason :)

@Bakual
Copy link
Contributor Author

Bakual commented May 16, 2017

Pinging @andrepereiradasilva since it looks like this was done with #11830 (and related ones)

@infograf768
Copy link
Member

I guess no special reason at looking at the original pr.
I also see no reason to change that as toolbar and modals are quite different things.

@brianteeman
Copy link
Contributor

@Bakual you are very very unlikely to get a reply from @andrepereiradasilva

@Bakual
Copy link
Contributor Author

Bakual commented May 19, 2017

Looks like

@dgrammatiko
Copy link
Contributor

For what it's worth: in the mobile era the dominant buttons tend to lay on the right hand of the screen (easily accessed using one hand), but then again people in the community still believe that the admin area is not for mobiles...

@brianteeman
Copy link
Contributor

And that assumes everyone is right handed. It's certainly not easier if you are left handed

@Bakual
Copy link
Contributor Author

Bakual commented May 19, 2017

The admin area can be used with mobiles, but more often it is used on desktops. That's not only a believe.
I'm not saying it's wrong that it is on the right side. I just found it a bit confusing as the order is different in that new modal compared to a regular form ("old" modals had them left like the toolbar).

@brianteeman
Copy link
Contributor

I am closing this based on the lack of any overwhelming reason to change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants