Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue 11760 is missed on issues.joomla.org #871

Closed
zero-24 opened this issue Aug 23, 2016 · 16 comments
Closed

issue 11760 is missed on issues.joomla.org #871

zero-24 opened this issue Aug 23, 2016 · 16 comments

Comments

@zero-24
Copy link
Contributor

zero-24 commented Aug 23, 2016

Steps to reproduce the issue

Issues.joomla.org

Expected result

See the entry there

Actual result

No entry for joomla/joomla-cms#11760

System information (as much as possible)

Additional comments

@zero-24
Copy link
Contributor Author

zero-24 commented Aug 23, 2016

Looks like we have a general bot issue?

https://issues.joomla.org/tracker/joomla-cms/11694

Misses the last comments from
joomla/joomla-cms#11694 (comment)

@mbabker
Copy link
Contributor

mbabker commented Aug 23, 2016

I'm getting really tired of ModSec...

@zero-24
Copy link
Contributor Author

zero-24 commented Aug 23, 2016

😄 How did it work before?

@mbabker
Copy link
Contributor

mbabker commented Aug 23, 2016

Odds are the old server didn't have ModSec on it.

@zero-24
Copy link
Contributor Author

zero-24 commented Aug 23, 2016

Ok. Hmm but there should be a way to consume github hooks in a secure way do we have a way to contact github?

@mbabker
Copy link
Contributor

mbabker commented Aug 23, 2016

It's not GitHub, it's Rochen.

@zero-24
Copy link
Contributor Author

zero-24 commented Aug 23, 2016

I mean ask github to get a secure configuration of mod security they have maybe some expirience in that? Or Rochen ask github howto configure it secure?

@zero-24
Copy link
Contributor Author

zero-24 commented Aug 23, 2016

Can we do something like
https://developer.github.com/webhooks/securing/

@mbabker
Copy link
Contributor

mbabker commented Aug 23, 2016

Supposedly Rochen whitelisted GitHub stuff based on the data I gave them. Apparently that's not happening.

The problem is our issues commonly have SQL scripts, JavaScript snippets, and HTML inlined into them. Which triggers the rules long before our application runs.

And that page is only good for application level security measures. It does nothing to address the web server stripping stuff.

@zero-24
Copy link
Contributor Author

zero-24 commented Aug 23, 2016

Hmm thanks for checking

@zero-24
Copy link
Contributor Author

zero-24 commented Aug 23, 2016

Hmm loks like that the cron synced it.. So we need to add our logic to the crons too? Like pending and labels?

@mbabker
Copy link
Contributor

mbabker commented Aug 23, 2016

So #692 needs to be synced, tested, and merged is what you're saying.

And the cron works fine because it initiates a request to GitHub's API and pulls the data as a response whereas the webhooks send the request to our server. ModSecurity only filters incoming HTTP traffic, unless someone REALLY screwed up a configuration it shouldn't filter data from a curl request inside a PHP app.

@mbabker
Copy link
Contributor

mbabker commented Aug 23, 2016

BTW anyone with admin rights on whatever repo is having issues can check the webhook configurations on GitHub as it shows the log of all of the transactions and success/fail status. You end up with something like the below meaning our server is once again misconfigured.

screen shot 2016-08-23 at 9 31 29 am

@zero-24
Copy link
Contributor Author

zero-24 commented Aug 23, 2016

i don't have admin rights on github repos. But also resending that would fail, correct?

@mbabker
Copy link
Contributor

mbabker commented Aug 23, 2016

Correct.

@mbabker
Copy link
Contributor

mbabker commented Aug 23, 2016

Per Rochen:

Apache was rebuilt on the following the whitelisting I did previously; I've reapplied the changes now

@mbabker mbabker closed this as completed Aug 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants