Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Bot don't run for the CMS Issue #11353 #850

Closed
zero-24 opened this issue Jul 30, 2016 · 12 comments
Closed

The Bot don't run for the CMS Issue #11353 #850

zero-24 opened this issue Jul 30, 2016 · 12 comments

Comments

@zero-24
Copy link
Contributor

zero-24 commented Jul 30, 2016

Steps to reproduce the issue

see: joomla/joomla-cms#11353 & https://issues.joomla.org/tracker/joomla-cms/11353

Expected result

PR-staging & RTC label

Actual result

no label

Additional comments

It looks like that the bot don't run on that issue?

@brianteeman
Copy link
Contributor

I noticed that there was no label (eg pr-staging) and thought that might be related so i have now added that label

@zero-24
Copy link
Contributor Author

zero-24 commented Jul 30, 2016

same issue applys to: joomla/joomla-cms#11359

@mbabker
Copy link
Contributor

mbabker commented Jul 31, 2016

mod_security looks to be blocking the webhooks still.

@zero-24
Copy link
Contributor Author

zero-24 commented Aug 6, 2016

again mod_security on joomla/joomla-cms#11497 ?

@zero-24
Copy link
Contributor Author

zero-24 commented Aug 8, 2016

Can we do something about the mod_security issue? joomla/joomla-cms#11056

@brianteeman
Copy link
Contributor

It happens more than the above as I didn't bother to report it if I could make the change

@mbabker
Copy link
Contributor

mbabker commented Aug 8, 2016

We can't get mod_security completely turned off here. I don't have time to dig into every webhook that's failing but that last one the issue has SQL statements included in at least one comment's payload and joomla/joomla-cms#11359 could be deciphered as XSS by mod_security.

@zero-24
Copy link
Contributor Author

zero-24 commented Aug 8, 2016

Ah ok. That explains it so if that fails the maintainer need to add them manually. Thanks.

@zero-24 zero-24 closed this as completed Aug 8, 2016
@mbabker
Copy link
Contributor

mbabker commented Aug 8, 2016

It shouldn't need to be manually but remember there are webhook payloads that are going to trigger a mod_security rule with a default configuration. So if there's going to be a whitelist around it then it has to be a very explicit configuration.

@elkuku
Copy link
Contributor

elkuku commented Aug 8, 2016

Could we use the CLI script to sync those issues with "security problems"?

@mbabker
Copy link
Contributor

mbabker commented Aug 8, 2016

Should be doing that already since it'd be bypassing mod_security. It just doesn't give the instant gratification that the webhooks do, and I don't believe the CLI scripts are doing all the automated stuff that the webhooks do.

@elkuku
Copy link
Contributor

elkuku commented Aug 8, 2016

Yeah the "event" stuff is still missing. There is a proposal in #692 ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants