-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
many files can NOT be detected and listed by com_localise #279
Comments
hi, infograf768 , from your post, I noticed a funny issue: The file en-GB.plg_kunena_joomla.sys.ini is located in this folder in my test: /administrator/components/com_kunena/language/en-GB But on your first screenshot, it seems that this file was in this folder: /administrator/language/en-GB Why so different? Well, let us return to the original question: why com_localise will "miss" so many files? You had mentioned some "suffix" cause, but my further question is: Why SHOULD I remember so many suffixes? I think the author of com_localise should modify the rules which will be used to recognize language files. This is a translating tool, it should work in a simple way: find out language files having same filenames (except the language tag part of course) and compare them ! Do not ask users to remember and input so many suffixes there! We don't know what kind of a new suffix will be used by another extension developer. I think we should not worry about this. Just compare the filename's part after the language tag and list them all there. Thank you. |
Look better: the path is to /administrator/language/fr-FR not en-GB.
You are welcome to propose patches. This component development is depending on volunteers. There is no single author. I will try to look at that though and see what we can do. |
After checking the code, I am not sure we can even do that (i.e. using an underscore instead of the dot).
If we do not specify all these variables, we are in bad shape, not only to retrieve the files, but also to save the translated files with the same name (except the $tag). Basically what you ask for is totally different from present com_localise as integrated in joomla. FYI, en-GB.finder_cli.ini is treated as a special case in com_localise. |
Do you remember Translations Manager for Joomla 1.5? Which com_localise claimed to based on. You can make a test: on Joomla 1.5 installation, you intall Translations Manager component, then, copy Kunena 4.x language files to appropriate folders of this Joomla 1.5, and you visit Translations Manager backend, you will find out that it will CORRECTLY find language files and compare them! Does Translations Manager require any suffix input? No. It doesn't. I don't know how Translations Manager works, but I think this is a better way. Why com_localise did not follow this way? |
In 1.5, we did not have a language folder in the extension. All ini files were in core folders. |
Since Joomla 3.x has a language folder in extension folder, so we need to MANUALLY input some suffixes to enable com_localise to recognize language files in those folders? This does not make any sense! |
We need some suffix only when some coders have defined weird ini files names. But, as I said, you are welcome to propose patches. The code is in |
I "may" have found a way, but it implies extensive changes and filtering issues. |
Today I downloaded the latest dev version (v4.0.12-dev) of com_localise and tested it on Joomla 3.4.3 with Kunena 4.0.3 language files.
There are totally 15 language files in the backend language file folder of Kunena, but com_localise can only recognize and list 11 files!
Why the other 7 files were not detected and listed?
The text was updated successfully, but these errors were encountered: