Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Links in Search results open in parent window instead of new window (global) #399

Open
kofaysi opened this issue Mar 30, 2019 · 3 comments

Comments

@kofaysi
Copy link
Contributor

kofaysi commented Mar 30, 2019

Steps to reproduce the issue

Set Global configuration > Web Links > Target > Open in new window
Search (finder / smart search) for a weblink name which has Target set to Global
Open the link of the weblink in the search results.

Expected result

Opens in new window.
Link structure should be:
index.php?option=com_weblinks&task=weblink.go&id=119&Itemid=591

Actual result

Opens in parent window.
Links structure is
index.php?option=com_weblinks&view=weblink&id=119:weblink-name&catid=90&Itemid=591

System information (as much as possible)

Joomla 3.9.4

Additional comments

@HLeithner
Copy link
Contributor

@Hackwar can you look at this please?

@Hackwar
Copy link
Contributor

Hackwar commented Apr 26, 2019

Seems like the finder plugin needs updating. However opening in a new window is not an option in finder. I'm very hesitant to add such an option, too.

@Hackwar
Copy link
Contributor

Hackwar commented Jun 16, 2019

So I've looked into this again and I'm unsure if this is to be considered a bug or not. We can't change this in the master branch, since that would be a break in B/C, but if this is really wanted, we can do that for the next major release and then add a switch for this. Because frankly, the behavior seems right both ways. In any case, I don't want to add the option for the target to com_finder.

What would you prefer here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants