Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot receive the dismissCompletion event #36

Closed
LiDevil opened this issue Jan 5, 2024 · 3 comments
Closed

Cannot receive the dismissCompletion event #36

LiDevil opened this issue Jan 5, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@LiDevil
Copy link

LiDevil commented Jan 5, 2024

hello ,i am facing a issues that if i using dismiss(animated: true) instead of swipe-down or just tapping on an empty space, the dismissCompletion cannot be received ,how to solve it , thanks you
@mikhailmaslo mikhailmaslo mentioned this issue Jan 6, 2024
Merged
@mikhailmaslo mikhailmaslo assigned LiDevil and unassigned LiDevil Jan 6, 2024
@mikhailmaslo
Copy link
Collaborator

Hello @LiDevil!

Thank you for letting me know about this inconsistency. Fixed it here #37

May I ask you to take a look at this PR to make sure it addresses your issue? As soon as I'll get your approve, I can merge to the main branch

@mikhailmaslo mikhailmaslo added the bug Something isn't working label Jan 6, 2024
@LiDevil
Copy link
Author

LiDevil commented Jan 8, 2024 •
edited
Loading

Hello @LiDevil!

Thank you for letting me know about this inconsistency. Fixed it here #37

May I ask you to take a look at this PR to make sure it addresses your issue? As soon as I'll get your approve, I can merge to the main branch

Yes, i follow the code change, it fix my pr ,thank you, expecting your update

@LiDevil LiDevil closed this as completed Jan 8, 2024
@mikhailmaslo
Copy link
Collaborator

Released in 2.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LiDevil @mikhailmaslo