-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return ReadableStream #21
Comments
with regards to #19 (cancellation) the way you would do it with ReadableStream is by calling |
Played a bit myself with streams and monkey patching xhr: This is how i would do it for firefox: https://jsfiddle.net/98L105v3/2/ |
Thanks @jimmywarting this was an excellent suggestion; I've incorporated your ideas into #20 - I would appreciate your feedback and also any input you and @ariutta have on the future surface API of this library. |
Now when i look back at my monkey patch I like it since you can choose to overide it or get a new extended xhr (: |
How about actually get a ReadableStream back instead of writing a own custom onChunk callback
With ReadableStream you would be able to pipeTo & pipeThrogh others streams
With web-stream-polyfill (npm) this would be a breeze
The text was updated successfully, but these errors were encountered: