Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scalar indexing of a GPU array error #150

Closed
lungd opened this issue Jul 19, 2022 · 5 comments · Fixed by #151
Closed

Scalar indexing of a GPU array error #150

lungd opened this issue Jul 19, 2022 · 5 comments · Fixed by #151

Comments

@lungd
Copy link

lungd commented Jul 19, 2022

Zygote complains with a scalar indexing is disallowed error with #999c335.

My code does work without that change. Sorry, I don't have a MWE to share at the moment.
Maybe the problem could be that during the FW pass of my custom Lux model I move an array to the CPU before I use it to solve an ODE and then the solution back to the GPU?
In case it's impossible to tell what could cause the error, I can try to reduce my model to a MWE.

Feel free to close this issue if you think it's a duplicate of #126

@YichengDWu
Copy link
Contributor

If you have moved the array to the CPU how could it complain about scalar indexing? Please put together a MWE

@avik-pal
Copy link
Member

@jonniedie any reason the CRC rrule for getproperty was added. It breaks compatibility with CuArrays. See LuxDL/Lux.jl#92

@YichengDWu
Copy link
Contributor

The last update is for fixing #148 I opened 🥲. A few hours ago I was celebrating the fact that it got fixed. Maybe we can try to figure out how to fix it while avoiding scalar indexing

@YichengDWu
Copy link
Contributor

The PR #151 will fix both.

@lungd
Copy link
Author

lungd commented Jul 21, 2022

Awesome. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants