Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save file to path which includes shell meta character #35

Merged
merged 1 commit into from
Sep 11, 2017
Merged

Save file to path which includes shell meta character #35

merged 1 commit into from
Sep 11, 2017

Conversation

fujimura
Copy link
Contributor

Path for saved file wasn't escaped and throwing exception below.

Grim::UnprocessablePage:
   sh: -c: line 0: syntax error near unexpected token `('
   sh: -c: line 0: `convert -resize 1024 -antialias -render -quality 90 -colorspace RGB -interlace none -density 300 /Users/fujimura/.ghq/github.com/jonmagic/grim/spec/fixtures/smoker.pdf[0] /Users/fujimura/.ghq/github.com/jonmagic/grim/tmp/to_png_spec(1).png'

@jonmagic jonmagic merged commit 536291a into jonmagic:master Sep 11, 2017
@jonmagic
Copy link
Owner

Merged, updated the contributors list, and shipped version 1.3.3. Thank you for the contribution @fujimura 🤘

@fujimura fujimura deleted the save-file-to-path-which-includes-shell-meta-character branch September 12, 2017 02:39
@fujimura
Copy link
Contributor Author

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonmagic jonmagic jonmagic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fujimura @jonmagic