Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Failure public #88

Open
rustworthy opened this issue Nov 19, 2024 · 1 comment
Open

Make Failure public #88

rustworthy opened this issue Nov 19, 2024 · 1 comment

Comments

@rustworthy
Copy link
Collaborator

Users should be able to read Failure's fields.

There is also a field in that structure not covered just yet called remaining, meaning the number of remaining retry attempts.

We will probably want to implement #61 first, so that we can "force-push" failed jobs from retries set to sheduled set, then

  • in our test - consume the job again and examine it's failure field via Job::failure getter. Currently, we would have to wait for the Faktory server to do so or - alternatively - go to the Web UI and re-queue the job from there, which is - in both cases - not suitable for auto-tests.
@jonhoo
Copy link
Owner

jonhoo commented Nov 19, 2024

That seems reasonable to me! Though let's make sure we set it to #[non_exhaustive].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants