clockwork: use non-zero time in NewFakeClock #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lgtm |
jonboulle
added a commit
that referenced
this pull request
Dec 16, 2014
clockwork: use non-zero time in NewFakeClock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The built-in time package provides a function to check whether or not a given Time object represents Time's zero-value: http://golang.org/pkg/time/#Time.IsZero. The current logic in NewFakeClock returns a time that fulfills IsZero. Users of this library that care about the IsZero distinction will get different results when using the fake clock vs the real clock. Simply using a standard time in the past after time zero gets us a static point in time we can use for comparison.