Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release? #93

Open
jonathangjertsen opened this issue Nov 5, 2024 · 7 comments
Open

Release? #93

jonathangjertsen opened this issue Nov 5, 2024 · 7 comments

Comments

@jonathangjertsen
Copy link

Hi! The last release was made April 2023, and some work has been done since then (such as adding Until to the interface). Is there a plan for creating a more updated release?

@DPJacques
Copy link
Collaborator

I have no strong feelings, but I have also never done a release on github.

Is this something you can send a PR for. If you want to use the current master branch as the latest release (1.5?), that is fine with me.

I'd also use it as an opportunity to learn how to do it first hand, so we can bump it again assuming #94 is resolved in a way that adds context features.

@jonathangjertsen
Copy link
Author

Someone with write access to the repository will have to follow these steps: https://docs.github.com/en/repositories/releasing-projects-on-github/managing-releases-in-a-repository this was last done by @sagikazarmark

There is some yaml in the .github folder which looks like it will generate (part of) a changelog for the README

@sagikazarmark
Copy link
Collaborator

Here is how I usually do it:

  • git tag -a -m "Release 0.X.0" v0.X.0 (I usually also sign tags with my GPG key)
  • git push v0.X.0
  • create a release on GH, generate change log on the UI

(Note: we use a v prefix in version tags in this repo and there is really nothing that can go wrong during tagging (we can always release a new version) except leaving the prefix out which is why I'm highlighting it)

I can do it if you want me to, but feel free to take the lead @DPJacques.

@DPJacques
Copy link
Collaborator

@sagikazarmark if this is fast/easy for you and you want to execute it, I wouldn't be opposed :)

If not, I'm going to try to look into this this weekend, just because I need to set up GPG keys and make sure I roughly understand what I am doing.

@sagikazarmark
Copy link
Collaborator

@DPJacques Sure, no problem. Are we ready for a new release? Or still waiting on some PRs?

@DPJacques
Copy link
Collaborator

DPJacques commented Dec 3, 2024

I think we have everything we need. The contexts from #92 are a big feature. There are also some minor bug fixes. So far I haven't seen any issues with Go 1.23 (#84), but I don't have the confidence to say we should close it out at this point.

@sagikazarmark
Copy link
Collaborator

I'll tag a release later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants