You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
In case background_image/background_image_dark are used, but not color or image, then the light resources for branding and background image are used in dark mode.
The issue appears to come from the following in cli_command.dart:
In case we only set background_image_dark, then both darkImage and darkColor will be null, thus brandingDarkImage and darkBackgroundImage will be replaced by their light version.
I tried to fix it in #350, but it appears the fix was incorrect.
Describe the bug
In case
background_image
/background_image_dark
are used, but notcolor
orimage
, then the light resources for branding and background image are used in dark mode.The issue appears to come from the following in cli_command.dart:
In case we only set
background_image_dark
, then bothdarkImage
anddarkColor
will be null, thusbrandingDarkImage
anddarkBackgroundImage
will be replaced by their light version.I tried to fix it in #350, but it appears the fix was incorrect.
To Reproduce
With the following configuration
Expected behavior
The dark background image is used in dark mode when only
background_image
/background_image_dark
are used.The text was updated successfully, but these errors were encountered: