Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove restriction that messages are exactly 32 bytes #22

Closed
jonasnick opened this issue May 25, 2022 · 3 comments · Fixed by #52
Closed

Remove restriction that messages are exactly 32 bytes #22

jonasnick opened this issue May 25, 2022 · 3 comments · Fixed by #52

Comments

@jonasnick
Copy link
Owner

jonasnick commented May 25, 2022 •
edited
Loading

(as discussed here bitcoin-core/secp256k1#995 (comment))
@real-or-random
Copy link
Collaborator

Related: sipa#221

@real-or-random
Copy link
Collaborator

This has been solved by #24.

But when working on sipa#221, I realized we should have at least test vector with a message larger than 32 bytes. This will catch implementations that truncate the message at 32 bytes.

@jonasnick jonasnick mentioned this issue Aug 17, 2022
Merged
@jonasnick
Copy link
Owner Author

@real-or-random good point. I added test vectors in #52.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add test vectors for messages longer than 32 bytes jonasnick/bips
2 participants
@real-or-random @jonasnick