Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a file path into an error message while reading a file fixes #405 #212

Merged
merged 1 commit into from
Aug 9, 2018
Merged

Added a file path into an error message while reading a file fixes #405 #212

merged 1 commit into from
Aug 9, 2018

Conversation

LukasRychtecky
Copy link
Contributor

Hi,

I've added a file name into an error message and I think it'd be helpful.

screen shot 2018-03-01 at 16 45 50

@LukasRychtecky
Copy link
Contributor Author

@jonase Do you have any comments?

@arrdem
Copy link
Collaborator

arrdem commented Aug 8, 2018

@danielcompton any comment? I'm not opposed, fixing the redundant println format to printf is easy enough.

@danielcompton
Copy link
Member

Seems reasonable to me.

@danielcompton danielcompton merged commit 1d6fa49 into clj-commons:master Aug 9, 2018
@danielcompton
Copy link
Member

danielcompton commented Aug 9, 2018 •
edited
Loading

printf change sounds good. Happy for you to do it, or I'll get to it eventually.

@LukasRychtecky LukasRychtecky deleted the 205_File-name branch August 9, 2018 07:46
@LukasRychtecky
Copy link
Contributor Author

Thx!

@pedro-w pedro-w mentioned this pull request Aug 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LukasRychtecky @arrdem @danielcompton