-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Todo : find why STBI_ONLY_JPEG breaks Alignment mark #1779
Comments
The images as seen in the Recognition page are stored on the sd-card as BMP images, see I guess thats the reason. We should check with @jomjol what the reason to pick BMP is. Maybe it simply could be switched to JPG as well? |
Bitmaps are choosen, because I wanted to avoid lossed due to compression. If we would change the settings of the jpeg, that might work as well. |
thanks! I think if you set the jpeg compression to minimum it should be ok |
Would be needed to test. |
I tested your PR #1789 and it works for me. If it breaks the backwards compatibility,what impact does this have? |
I checked everything and it does not break the backward compatility. I made a mistake while checking. So we can implement this change. |
fixed in #1789 |
The Feature
As mentionned in #1721 ,STBI_ONLY_JPEG breaks alignment marks
STBI_ONLY_JPEG can save 2% of Flash
Todo :
debug the alignment marks to find why ClassFlowAlignment.h is linked to stb_image.h
I did not find why :
ClassFlowAlignment.h includes CAlignAndCutImage.h
CAlignAndCutImage.h includes CImageBasis.h (works if STBI_ONLY_JPEG enabled)
CImageBasis.h includes stb_image.h ( works if STBI_ONLY_JPEG enabled)
The text was updated successfully, but these errors were encountered: