feat(ml): add lambda #661
Open
feat(ml): add lambda #661
+33
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beniz
reviewed
Jun 20, 2024
models/cm_gan_model.py
Outdated
| @@ -24,6 +24,8 @@ def __init__(self, opt, rank): | |||
| visual_names_B = ["real_B"] | |||
| self.visual_names.append(visual_names_A) | |||
| self.visual_names.append(visual_names_B) | |||
| self.variable1 = 0.6 | |||
beniz
reviewed
Jun 20, 2024
util/parser.py
Outdated
| @@ -31,7 +31,7 @@ def get_opt(main_opt, remaining_args): | |||
| ) | |||
|
|
|||
| # Save the config file when --save_config is passed | |||
| is_config_saved = False | |||
| is_config_saved = True # False | |||
There was a problem hiding this comment.
If i don not set this into True, I can not have train_config.json file, then, can not do the inference. I'll see if there has other ways
There was a problem hiding this comment.
There has no config_save option description in the joliGEN.
|
I think I do not fully get your idea to "add lambda_gan to self and then to visual_names for it to be plotted." I thought lambda_gan should appear in a separate Visdom window? P.S.: This modification does not display the lambda, and I do not get why use detach here. since in the loss.py , the fake image tensor has already get detached for calculation. |
royale
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add function lambda into cm_gan_model
The training works with the following command line
The inference works with the following command line